feat: add build parameter for AzureLinuxV3 CVM Gen2 in VHD builder pi… #5755
+717
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplethevoyager
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
…nd release pipeline
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
pineapplethevoyager
temporarily deployed
to
test
GitHub Actions
Inactive
| @@ -36,7 +36,7 @@ capture_benchmark "${SCRIPT_NAME}_declare_variables_and_source_packer_files" | |||
| echo "Logging the kernel after purge and reinstall + reboot: $(uname -r)" | |||
| # fix grub issue with cvm by reinstalling before other deps | |||
| # other VHDs use grub-pc, not grub-efi | |||
| if [[ "${UBUNTU_RELEASE}" == "20.04" && "$IMG_SKU" == "20_04-lts-cvm" ]] || [[ "${UBUNTU_RELEASE}" == "24.04" && "$IMG_SKU" == "cvm" ]]; then | |||
| if [ "${OS_TYPE}" == "Ubuntu" ] && grep -q "cvm" <<< "$FEATURE_FLAGS"; then | |||
There was a problem hiding this comment.
This should check OS_SKU, OS_TYPE will be either Linux or Windows
| - name: buildAzureLinuxV3cvmgen2 | ||
| displayName: Build AzureLinuxV3 CVM Gen2 | ||
| type: boolean | ||
| default: true |
There was a problem hiding this comment.
Should this be true from the start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
add build parameter for AzureLinuxV3 CVM Gen2 in VHD builder pipeline
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: