Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validateWorkersVersions.ps1 script #4245

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Jan 31, 2025

Issue describing the changes in this PR

With the refactor of the host, each Worker.props file has been split into eng/build/Worker.[WorkerName].props, rather than having the worker references directly in the csproj. The validateWorkersVersions.ps1 script has been updated to reflect this change.

Example of running validateWorkerVersions.ps1 -Update -HostVersion 4.1037.0:
image

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
  • I have added all required tests (Unit tests, E2E tests)

@aishwaryabh aishwaryabh requested a review from a team as a code owner January 31, 2025 23:19
jviau
jviau previously approved these changes Jan 31, 2025
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming to realize how much manual ingestion of the host repo the core tools repo has. Would be good to see how we can decouple this in the future.

liliankasem
liliankasem previously approved these changes Jan 31, 2025
@Francisco-Gamino
Copy link
Contributor

Thank you @aishwaryabh for updating this script. Could you please port this change to the in-proc branch? Thanks again.

@aishwaryabh aishwaryabh requested a review from a team as a code owner February 4, 2025 20:16
@aishwaryabh aishwaryabh merged commit e079aed into main Feb 5, 2025
10 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/fix-update-script branch February 5, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants