Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata.json file #4289

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Mar 6, 2025

Issue describing the changes in this PR

The metadata.json file was not being generated correctly due to a bug in the script for parsing the visual studio files to have a .zip ending in the name, which is not valid anymore. This PR fixes the bug by updating the regular expression to match the correct file name.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@aishwaryabh aishwaryabh requested a review from a team as a code owner March 6, 2025 19:56
@kshyju
Copy link
Member

kshyju commented Mar 7, 2025

which is not valid anymore

Can you remind me why this is not valid anymore? since when? May be an example of the file name?

@aishwaryabh
Copy link
Contributor Author

which is not valid anymore

Can you remind me why this is not valid anymore? since when? May be an example of the file name?

Yeah so in this PR, I added a step in the consolidated pipeline where only zip up the VS artifacts after the testing has been done. Therefore, when this step is run, which is before the zipping up of the files, the script fails to find a file that ends with .zip. I just removed that filter for finding a file that ends with .zip to account for this change.

@aishwaryabh aishwaryabh merged commit bb4c949 into main Mar 10, 2025
11 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/fix-metadata-json-generator branch March 10, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants