Skip to content

Fix invocation timeout when incoming request contains "x-ms-invocation-id" header #10980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 14, 2025

Conversation

satvu
Copy link
Member

@satvu satvu commented Apr 1, 2025

Issue describing the changes in this PR

resolves #10934

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- I'd recommend sync'ing with @jviau or @fabiocav -- I recall one of them mentioning that we may need to store the original header? I'm not sure that we do, but they would likely have more details.

@satvu satvu requested a review from brettsam April 22, 2025 21:06
@satvu satvu marked this pull request as ready for review April 22, 2025 21:06
@satvu satvu requested a review from a team as a code owner April 22, 2025 21:06
@satvu satvu requested a review from jviau April 22, 2025 21:06
@jviau
Copy link
Contributor

jviau commented Apr 25, 2025

This looks good -- I'd recommend sync'ing with @jviau or @fabiocav -- I recall one of them mentioning that we may need to store the original header? I'm not sure that we do, but they would likely have more details.

I am struggling to recall this exactly. But my guess would be something along the lines of putting the existing header into a new header, like x-ms-orig-invocation-id, so the function still has access to it, but it doesn't interfere with our system.

@satvu satvu requested a review from brettsam April 28, 2025 20:40
@fabiocav
Copy link
Member

I'm OK with us scoping the changes to what is currently in place. If we feel there's a need for us to maintain the original header (I don't think we've been able to identify valid scenarios for that), we can introduce that in another PR. That would also lead to questions about hops across multiple Function Apps.

@satvu satvu merged commit 006d6bb into dev May 14, 2025
9 checks passed
@satvu satvu deleted the satvu/fix-invocation-timeout-due-to-header branch May 14, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invocation can time out if incoming request contains "x-ms-invocation-id" header
6 participants