Skip to content

Remove hardcoded Windows env var for JAVA_HOME #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove hardcoded Windows env var for JAVA_HOME #516

wants to merge 1 commit into from

Conversation

brunoborges
Copy link
Member

@brunoborges brunoborges commented Jan 18, 2022 •
edited
Loading

Issue describing the changes in this PR

This fixes #421. The bug described in #421 also affects running Azure Functions on Linux and on Windows Subsystem for Linux, besides macOS.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'worker.config.json' configuration hardcoded for Windows
1 participant
@brunoborges