Fix AddProductColumnTypesTest for Java #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
chlafreniere and
MaddyDev
as code owners
Charles-Gagnon
approved these changes
Dec 1, 2022
MaddyDev
approved these changes
Dec 1, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* enable addproductcolumntypestest for java * add to known issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #521
The test was failing on the linux pipeline because the timestamp object being sent to the database had an extra comma between the date and the time.
Mac/Windows: "Dec 1, 2022 11:55:45 AM"
Linux: "Dec 1, 2022, 4:45:52 PM"
Using java.sql.Date instead of java.sql.Timestamp fixes the issue.