Add more datatypes to ProductsColumnTypes tests #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
chlafreniere,
MaddyDev and
VasuBhog
as code owners
lucyzhang929
commented
Jan 19, 2023
| @@ -1,11 +0,0 @@ | |||
| # Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
ProductColumnTypes is only used in test-python folder.
Charles-Gagnon
approved these changes
Jan 20, 2023
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* get started on adding datatypes * Fix TIME in Java * fix java test * GetProductsColumnTypesSerializationAsyncEnumerable * add product column types test * fix linting * remove productcolumntypes in samples-python * cleanup * cleanup * add unicode * skip java addproductcolumntypestest * add unicode to java and python test * fix space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking missing types here: #634
AddProductColumnsTest is being skipped for Java because of datetime format issue on Linux (test is passing on Windows):
#521. Will investigate and document any workarounds for this.