Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoT messaging payload update #653

Merged
merged 19 commits into from
Apr 22, 2023
Merged

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented Apr 12, 2023

Add file path input for iot messaging and add non-decodable content handler for event monitoring

This pr is to address the 3 github issues below:

pipeline run: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8186&view=results

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever Elsie4ever changed the title User/jiacju/binaryinfile IoT messaging payload update Apr 12, 2023
@Elsie4ever Elsie4ever requested a review from c-ryan-k April 13, 2023 17:13
@Elsie4ever Elsie4ever marked this pull request as ready for review April 13, 2023 17:13
Copy link
Member

@digimaun digimaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review chunk.

@digimaun
Copy link
Member

Here is issue link for 3rd item in PR description Azure/azure-cli-extensions#4966

@Elsie4ever Elsie4ever assigned Elsie4ever and unassigned Elsie4ever Apr 19, 2023
@Elsie4ever
Copy link
Contributor Author

Have ran serveral time after the test fix and verified the test stopped failing https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8230&view=results

@Elsie4ever Elsie4ever merged commit 509e067 into Azure:dev Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants