Skip to content

Alerts PageCount default value 25 #27540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025
Merged

Alerts PageCount default value 25 #27540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d865a6
page count default 25
Avivskie Apr 10, 2025
036d36e
updating the changelog
Avivskie Apr 20, 2025
14ab1a6
Update ChangeLog.md
dolauli Apr 21, 2025
ef55e8c
Merge branch 'main' into bugfix/avhaddad/pagecount_default25
dolauli Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...t.Azure.Commands.AlertsManagement.Test.ScenarioTests.AlertTests/TestAlertChangeState.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Entries": [
{
"RequestUri": "/subscriptions/dd91de05-d791-4ceb-b6dc-988682dc7d72/providers/Microsoft.AlertsManagement/alerts?alertState=New&includeContext=false&includeEgressConfig=false&pageCount=0&timeRange=1h&api-version=2019-05-05-preview",
"RequestUri": "/subscriptions/dd91de05-d791-4ceb-b6dc-988682dc7d72/providers/Microsoft.AlertsManagement/alerts?alertState=New&includeContext=false&includeEgressConfig=false&pageCount=25&timeRange=1h&api-version=2019-05-05-preview",
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvZGQ5MWRlMDUtZDc5MS00Y2ViLWI2ZGMtOTg4NjgyZGM3ZDcyL3Byb3ZpZGVycy9NaWNyb3NvZnQuQWxlcnRzTWFuYWdlbWVudC9hbGVydHM/YWxlcnRTdGF0ZT1OZXcmaW5jbHVkZUNvbnRleHQ9ZmFsc2UmaW5jbHVkZUVncmVzc0NvbmZpZz1mYWxzZSZwYWdlQ291bnQ9MCZ0aW1lUmFuZ2U9MWgmYXBpLXZlcnNpb249MjAxOS0wNS0wNS1wcmV2aWV3",
"RequestMethod": "GET",
"RequestBody": "",
Expand Down
6 changes: 3 additions & 3 deletions ...nds.AlertsManagement.Test.ScenarioTests.AlertTests/TestGetAlertsFilteredByParameters.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions src/AlertsManagement/AlertsManagement/AlertCommands/GetAzureAlert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ public class GetAzureAlertCommand : AlertsManagementBaseCmdlet
/// Page count
/// </summary>
[Parameter(Mandatory = false,
ParameterSetName = AlertsListByFilterParameterSet,
HelpMessage = "Number of alerts to be fetched in a page.")]
ParameterSetName = AlertsListByFilterParameterSet,
HelpMessage = "Number of alerts to be fetched in a page.")]
[Parameter(Mandatory = false,
ParameterSetName = AlertsListByTargetResourceIdFilterParameterSet,
HelpMessage = "Number of alerts to be fetched in a page.")]
public int PageCount { get; set; }
ParameterSetName = AlertsListByTargetResourceIdFilterParameterSet,
HelpMessage = "Number of alerts to be fetched in a page.")]
public int PageCount { get; set; } = 25;

/// <summary>
/// Alert property to use while sorting
Expand Down
1 change: 1 addition & 0 deletions src/AlertsManagement/AlertsManagement/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Bugfix of default pageCount from 0 to 25.
* Introduced various new features by upgrading code generator. Please see detail [here](https://github.com/Azure/azure-powershell/blob/main/documentation/Autorest-powershell-v4-new-features.md).

## Version 0.6.3
Expand Down