[dataprotection]fix default rule name for blob policy#29171
[dataprotection]fix default rule name for blob policy#29171IannGeorges wants to merge 1 commit intoAzure:mainfrom
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix the default rule name for blob backup policies in the DataProtection module by changing the retention rule name from "Default" to "Default_OperationalStore" in the AzureBlob.json manifest file. However, this change introduces a critical bug rather than fixing one.
Changes:
- Modified the retention rule name in AzureBlob.json manifest from "Default" to "Default_OperationalStore"
| ], | ||
| "isDefault": true, | ||
| "name": "Default", | ||
| "name": "Default_OperationalStore", |
There was a problem hiding this comment.
The retention rule name "Default_OperationalStore" is inconsistent with its sourceDataStore type "VaultStore" (line 75). According to the naming convention observed in test recordings and other manifest files, retention rules should follow this pattern:
- When sourceDataStore is "OperationalStore", the name should be "Default_OperationalStore"
- When sourceDataStore is "VaultStore", the name should be "Default"
Since this retention rule has sourceDataStore set to "VaultStore", the name should remain "Default", not "Default_OperationalStore". This change introduces a bug where the rule name doesn't match the actual datastore type being used.
| "name": "Default_OperationalStore", | |
| "name": "Default", |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Please fix the failed tests - I believe they are caused by this change, and update the ChangeLog.md accordingly |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.