Adding Online Experimentation data-plane SDK#44980
Merged
Conversation
smichtch
force-pushed
the
feature/online-experimentation
branch
from
7b59f84 to
c6d5335
Compare
smichtch
force-pushed
the
feature/online-experimentation
branch
3 times, most recently
from
2bf51bd to
5c3f9da
Compare
smichtch
requested review from
a team,
JonathanGiles,
alzimmermsft,
anuchandy,
conniey,
joshfree,
lmolkova and
srnagar
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the Online Experimentation data-plane SDK including new model classes for experiment metric definitions, diagnostic details, and the corresponding client builder and service version implementations. Key changes include the addition of several new model classes, updated JSON (de)serialization handling for these models, and client builder enhancements for configuring and creating service clients.
Reviewed Changes
Copilot reviewed 87 out of 87 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ExperimentMetricValidationResult.java | Adds the model for validation results with isValid property and diagnostics collection. |
| DiagnosticDetail.java | Introduces the diagnostic details model used for validation errors. |
| ExperimentMetricType.java, ExperimentMetricDefinition.java, and various MetricDefinition classes | Define multiple metric types and their JSON (de)serialization behavior. |
| OnlineExperimentationClientBuilder.java & OnlineExperimentationServiceVersion.java | Implement client creation logic and service versioning for the SDK. |
| pom.xml, README.md, CHANGELOG.md, etc. | Package configuration and metadata updates supporting the new SDK. |
smichtch
requested review from
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
smichtch
force-pushed
the
feature/online-experimentation
branch
3 times, most recently
from
19b5f0c to
3fd8f15
Compare
srnagar
reviewed
May 14, 2025
smichtch
force-pushed
the
feature/online-experimentation
branch
from
1ab76ec to
bf85add
Compare
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
smichtch
force-pushed
the
feature/online-experimentation
branch
from
bf85add to
47e1f9e
Compare
weidongxu-microsoft
approved these changes
May 21, 2025
github-merge-queue Bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
May 21, 2025
fix #7418 Mostly to get this code snippet id be cspell friendly. Context Azure/azure-sdk-for-java#44980 (comment) Java code copied from geeksforgeeks :-)
smichtch
force-pushed
the
feature/online-experimentation
branch
from
9aeff0f to
d39ad77
Compare
Member
Author
|
@srnagar please review. Addressed the feedback on APIView: removed non-generated constructors and updated samples/tests accordingly. Added |
Member
Author
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
srnagar
reviewed
Jun 9, 2025
smichtch
force-pushed
the
feature/online-experimentation
branch
from
b5e6a0f to
cf60a83
Compare
srnagar
approved these changes
Jun 10, 2025
…cy version, use default code coverage thresholds.
smichtch
force-pushed
the
feature/online-experimentation
branch
from
b3455cf to
3b2ddb7
Compare
srnagar
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding Online Experimentation data-plane SDK (for
Microsoft.OnlineExperimentation/workspacesresources).TypeSpec PR: Azure/azure-rest-api-specs#33135
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines