ARB Comments GA5 Changes#50124
Merged
v-dharmarajv merged 2 commits intocallautomation/release/ga5from May 20, 2025
Merged
Conversation
…o use ROM. Removed length property from AudioMetadata. Recorded live tests.
v-dharmarajv
approved these changes
May 20, 2025
v-dharmarajv
merged commit ab052f8
into
callautomation/release/ga5
3 of 4 checks passed
v-dharmarajv
added a commit
that referenced
this pull request
Jul 7, 2025
* Adding the ga5 changes * updating the azure board review comments * updating the version * Fixing the apiviews * updating the answer failed comment * ARB Comments GA5 Changes (#50124) * Added internal class for TranscriptionMetadata. Converted AudioData to use ROM. Removed length property from AudioMetadata. Recorded live tests. * Exported latest API. * addressing comments * addressing comments * Added dtmf data in streaming data parser and added unit test. (#49992) * Added dtmf data in streaming data parser and added unit test. * Added dtmf meta data and speechRecognitionModelEndpointId property for transcription. * Removed dtmf meta data. * resolving conflicts * resolving conflicts * resolving conflicts * fixing the naming * removing set * Delete sdk/communication/Azure.Communication.CallAutomation/src/Models/Streaming/Transcription/TranscriptionMetaDataInternal.cs --------- Co-authored-by: Vinothini Dharmaraj <v-dharmarajv@microsoft.com> Co-authored-by: Vinothini Dharmaraj <146493756+v-dharmarajv@users.noreply.github.com> * fixing the connect failed event serializer error * fixing the media streaming error * Adding the locale in the transcription subscription * removing the required fields for the transport url * removing the couple of properties for the dtmf data * merging from main * fixing the tests * updating the changelog and version * removing merge changes * reverting the autorest change * updating the change log * reverting the auotest rest version * Update daily publishing to use a releaseJob (#50367) * updating the changelog and release date * merging a missing update from main in archetype-net-release * removing the spaces * Update archetype-net-release.yml * updating unreleased version number * updating main alpha version * Update archetype-net-release.yml * Update archetype-net-release.yml --------- Co-authored-by: v-saasomani <v-saasomani@microsoft.com> Co-authored-by: v-pivamshi <155710746+v-pivamshi@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
v-dharmarajv
added a commit
that referenced
this pull request
Jul 30, 2025
* Adding the ga5 changes * updating the azure board review comments * updating the version * Fixing the apiviews * updating the answer failed comment * ARB Comments GA5 Changes (#50124) * Added internal class for TranscriptionMetadata. Converted AudioData to use ROM. Removed length property from AudioMetadata. Recorded live tests. * Exported latest API. * addressing comments * addressing comments * Added dtmf data in streaming data parser and added unit test. (#49992) * Added dtmf data in streaming data parser and added unit test. * Added dtmf meta data and speechRecognitionModelEndpointId property for transcription. * Removed dtmf meta data. * resolving conflicts * resolving conflicts * resolving conflicts * fixing the naming * removing set * Delete sdk/communication/Azure.Communication.CallAutomation/src/Models/Streaming/Transcription/TranscriptionMetaDataInternal.cs --------- Co-authored-by: Vinothini Dharmaraj <v-dharmarajv@microsoft.com> Co-authored-by: Vinothini Dharmaraj <146493756+v-dharmarajv@users.noreply.github.com> * fixing the connect failed event serializer error * fixing the media streaming error * Adding the locale in the transcription subscription * removing the required fields for the transport url * removing the couple of properties for the dtmf data * merging from main * fixing the tests * adding the ga6 changes * version change to beta to unblock creating the apiview * removing merge conflicts files * updating the common package * adding the custom header and startrecordingfailed event * updating the change log * updating to ga communication identifier * GA6 Recorded Tests (#50557) * Recorded all live tests against ga6 pma endpoint. All tests pass successfully (verified with PLAYBACK). Pushed assets.json. * Removed PMA endpoint CallAutomationClient constructors. * Playback tests passed after recording. Pushed assets.json. * merging from main * running generate code * updating the GA communication identifier * Added call connected event fix on the event processor * updating readme link * Adding the appsource * updating the CommunicationIdentifierSerializer_2025_06_30 communication identifier * fixing the connect call event processor issue * updating comments * updating changelog * Addressing the apiview comments * Addressing the apiview comments * removing the reason code as its applicable on ly for media * Addressing Apiview comments * updating changelog * updating the changelog * updating unreleased * reverting version back to check-in the main as the ga6 release is going to delayed for while --------- Co-authored-by: v-saasomani <v-saasomani@microsoft.com> Co-authored-by: v-pivamshi <155710746+v-pivamshi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made according to ARB comments. AudioData now uses read-only memory (ROM). Length property from AudioMetadata has been removed. Added internal class for TranscriptionMetadata.
Live Transcription Correlation ID -> ba1436e2-2e1e-4d86-b04a-157901c28a87
OpenAI Voice Correlation ID -> 742a2790-3f0b-4eb5-a2a3-8c487f0c9eec