-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Sync eng/common directory with azure-sdk-tools for PR 13005 #54088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sync eng/common directory with azure-sdk-tools for PR 13005 #54088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR #13005, adding support for tracking TypeSpec project locations in package work items. The changes introduce a new SpecProjectPath property that captures the path to the spec project from the tsp-location.yaml file in package directories.
Key Changes
- Added
SpecProjectPathproperty to thePackagePropsclass to store the path to TypeSpec spec projects - Updated Azure DevOps work item functions to include and track the new
Custom.SpecProjectPathfield - Added logic to read
tsp-location.yamlfiles and extract the spec project directory path
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Package-Properties.ps1 | Adds SpecProjectPath property to PackageProps class and initializes it from tsp-location.yaml if present |
| eng/common/scripts/Save-Package-Properties.ps1 | Adds logging output for the new SpecProjectPath property during package property export |
| eng/common/scripts/Validate-All-Packages.ps1 | Passes SpecProjectPath parameter when creating/updating DevOps release work items |
| eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 | Adds Custom.SpecProjectPath field to work item queries, parameters, and update logic; includes conditional logic to update the field when it changes; removes title field comparison check |
| if ($specProjectPath) { | ||
| $fields += "`"Custom.SpecProjectPath=${specProjectPath}`"" | ||
| } |
Copilot
AI
Nov 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SpecProjectPath field is being added to the work item but there's no corresponding check in the change detection logic (lines 546-553) to detect when this field has changed. This means that if only SpecProjectPath changes in an existing work item, the update won't be triggered by this function.
Consider adding a change detection check similar to other fields:
if ($specProjectPath -ne $existingItem.fields["Custom.SpecProjectPath"]) { $changedField = "Custom.SpecProjectPath" }
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13005 See eng/common workflow