Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13005 See eng/common workflow

Copilot AI review requested due to automatic review settings November 22, 2025 00:32
@azure-sdk azure-sdk requested a review from a team as a code owner November 22, 2025 00:32
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 22, 2025
Copilot finished reviewing on behalf of azure-sdk November 22, 2025 00:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with changes from azure-sdk-tools PR #13005, adding support for tracking TypeSpec project locations in package work items. The changes introduce a new SpecProjectPath property that captures the path to the spec project from the tsp-location.yaml file in package directories.

Key Changes

  • Added SpecProjectPath property to the PackageProps class to store the path to TypeSpec spec projects
  • Updated Azure DevOps work item functions to include and track the new Custom.SpecProjectPath field
  • Added logic to read tsp-location.yaml files and extract the spec project directory path

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
eng/common/scripts/Package-Properties.ps1 Adds SpecProjectPath property to PackageProps class and initializes it from tsp-location.yaml if present
eng/common/scripts/Save-Package-Properties.ps1 Adds logging output for the new SpecProjectPath property during package property export
eng/common/scripts/Validate-All-Packages.ps1 Passes SpecProjectPath parameter when creating/updating DevOps release work items
eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 Adds Custom.SpecProjectPath field to work item queries, parameters, and update logic; includes conditional logic to update the field when it changes; removes title field comparison check

Comment on lines +534 to +536
if ($specProjectPath) {
$fields += "`"Custom.SpecProjectPath=${specProjectPath}`""
}
Copy link

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SpecProjectPath field is being added to the work item but there's no corresponding check in the change detection logic (lines 546-553) to detect when this field has changed. This means that if only SpecProjectPath changes in an existing work item, the update won't be triggered by this function.

Consider adding a change detection check similar to other fields:

if ($specProjectPath -ne $existingItem.fields["Custom.SpecProjectPath"]) { $changedField = "Custom.SpecProjectPath" }

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants