[AutoRelease] t2-servicenetworking-2025-04-23-64871(can only be merged by SDK owner) #40669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ServiceNetworking SDK with new API version defaults and model enhancements. Key changes include the update of default API version values from "2025-01-01" to "2025-03-01-preview", the addition of new model properties (such as those for IP access rules and security policy configurations) with explicit visibility settings, and corresponding updates to client configuration, documentation, and changelog with a version bump to "2.1.0b1".
Reviewed Changes
Copilot reviewed 51 out of 53 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| azure/mgmt/servicenetworking/operations/_operations.py | Removed outdated sys.version checks by directly importing MutableMapping; updated API version defaults in request builders. |
| azure/mgmt/servicenetworking/models/_models.py | Added new properties and updated rest_field calls with explicit visibility lists for enhanced model behavior. |
| azure/mgmt/servicenetworking/models/_patch.py, _enums.py, init.py | Introduced new models and enums (e.g. IpAccessRule, IpAccessRulesPolicy, IpAccessRulesSecurityPolicy, IpAccessRuleAction) and updated exports. |
| azure/mgmt/servicenetworking/aio/operations/* | Applied similar API version and MutableMapping import updates to the asynchronous operations. |
| _client.py, _configuration.py | Updated default API version and enhanced client instantiation (including dynamic resolution of cloud endpoints). |
| README.md, CHANGELOG.md | Updated Python version requirement to 3.9+ and documented the new features and version bump. |
| _serialization.py, _model_base.py | Streamlined headers and licensing blocks, with minor improvements in error message formatting for deserialization. |
Files not reviewed (2)
- sdk/servicenetworking/azure-mgmt-servicenetworking/_meta.json: Language not supported
- sdk/servicenetworking/azure-mgmt-servicenetworking/apiview-properties.json: Language not supported
ChenxiJiang333
approved these changes
May 8, 2025
msyyc
approved these changes
May 8, 2025
msyyc
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6098
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5828