[AutoRelease] t2-resource-2025-04-24-18098(can only be merged by SDK owner) #40705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package to version 23.4.0 and incorporates several changes to client configuration, including making the base_url parameter optional and deriving it from Azure cloud settings, as well as updating generated metadata and documentation.
- Bump version numbers from "23.3.0" to "23.4.0" in multiple _version.py files.
- Update various client classes to support optional base_url with dynamic endpoint resolution and add appropriate type casts.
- Revise documentation (README.md and CHANGELOG.md) and remove explicit client imports from the resource init.py to reflect a new modularization strategy.
Reviewed Changes
Copilot reviewed 934 out of 936 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azure/mgmt/resource/databoundaries/_version.py | Version bump update. |
| azure/mgmt/resource/databoundaries/_data_boundary_mgmt_client.py | Updated optional base_url handling and type casting in client initialization. |
| azure/mgmt/resource/changes/**/*.py | Similar client configurations updates and version bumps across sync and async operations and models. |
| azure/mgmt/resource/init.py | Removal of explicit client exports in favor of pkgutil extend_path. |
| azure-mgmt-resource/README.md | Documentation updates including Python version requirements and grammar corrections. |
| azure-mgmt-resource/CHANGELOG.md | Updated release history for version 23.4.0. |
Files not reviewed (2)
- sdk/resources/azure-mgmt-resource/_meta.json: Language not supported
- sdk/resources/azure-mgmt-resource/azure/mgmt/resource/changes/v2022_05_01/_metadata.json: Language not supported
Comments suppressed due to low confidence (2)
sdk/resources/azure-mgmt-resource/azure/mgmt/resource/databoundaries/_data_boundary_mgmt_client.py:101
- Please ensure that unit tests cover scenarios where 'base_url' is not provided so that the dynamic assignment via 'get_arm_endpoints' behaves as expected.
self._client: ARMPipelineClient = ARMPipelineClient(base_url=cast(str, base_url), policies=_policies, **kwargs)
sdk/resources/azure-mgmt-resource/azure/mgmt/resource/init.py:1
- The removal of explicit client exports from init.py is a breaking change; please verify that downstream dependencies are updated to import clients from their new locations.
__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore
| @@ -24,7 +24,7 @@ pip install azure-identity | |||
|
|
|||
| ### Authentication | |||
|
|
|||
| By default, [Azure Active Directory](https://aka.ms/awps/aad) token authentication depends on correct configure of following environment variables. | |||
| By default, [Azure Active Directory](https://aka.ms/awps/aad) token authentication depends on correct configuration of the following environment variables. | |||
There was a problem hiding this comment.
Fixed typo: 'configure' corrected to 'configuration'.
Copilot uses AI. Check for mistakes.
ChenxiJiang333
force-pushed
the
t2-resource-2025-04-24-18098
branch
from
2da71b2 to
45d0e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6084
Recording test fail, detailed info is in pipeline log(search keyword FAILED)!!!
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1025
BuildTargetingString
azure-mgmt-resource
Skip.CreateApiReview