Adversarial simulator add korean #40723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Korean language in the adversarial simulator by extending both the language suffix mapping and the supported languages enum.
- Added a mapping for the Korean language in the suffix mapping helper.
- Extended the SupportedLanguages enum to include the Korean code.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_helpers/_language_suffix_mapping.py | Added a Korean language mapping entry. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_constants.py | Extended SupportedLanguages enum with Korean. |
Comments suppressed due to low confidence (1)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_helpers/_language_suffix_mapping.py:17
- Consider adding a unit test to validate that the Korean language mapping returns the expected suffix.
SupportedLanguages.Korean: BASE_SUFFIX.replace("__language__", "korean"),
github-actions
bot
added
the
Evaluation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
w-javed
approved these changes
Apr 25, 2025
slister1001
approved these changes
Apr 28, 2025
bambriz
pushed a commit
to bambriz/azure-sdk-for-python
that referenced
this pull request
May 5, 2025
* aggregated binary threshold results for evaluators in metrics * handle when the right columns do not exist * Marking mypy, pylint, black as false * Add to constatns * typo * Adding korean to the supported languages --------- Co-authored-by: Nagkumar Arkalgud <[email protected]> Co-authored-by: Nagkumar Arkalgud <[email protected]>
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
* aggregated binary threshold results for evaluators in metrics * handle when the right columns do not exist * Marking mypy, pylint, black as false * Add to constatns * typo * Adding korean to the supported languages --------- Co-authored-by: Nagkumar Arkalgud <[email protected]> Co-authored-by: Nagkumar Arkalgud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines