Upload results for 1DP project #40725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for uploading evaluation results for the OneDP project by introducing a new logging function and updating related client calls.
- Introduces _log_metrics_and_instance_results_onedp to handle OneDP-specific logging.
- Branches _evaluate based on the type of azure_ai_project to select the appropriate logging approach.
- Adds the TokenScope enum and updates EvaluationServiceOneDPClient to accept metrics.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_utils.py | Adds the new OneDP logging function (_log_metrics_and_instance_results_onedp). |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py | Updates _evaluate to call the OneDP logging function when azure_ai_project is a string. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_constants.py | Introduces the TokenScope enum for token management. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/evaluation_onedp_client.py | Modifies create_evaluation_result to accept a new metrics parameter and uses create_or_update_version. |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_constants.py
Outdated
Show resolved
Hide resolved
| @@ -22,7 +22,7 @@ def __init__(self, endpoint: str, credential: Union[AzureKeyCredential, "TokenCr | |||
| **kwargs, | |||
| ) | |||
|
|
|||
| def create_evaluation_result(self, *, name: str, path: str, version=1, **kwargs) -> None: | |||
| def create_evaluation_result(self, *, name: str, path: str, version=1, metrics: Dict[str, int]=None, **kwargs) -> EvaluationResult: | |||
There was a problem hiding this comment.
The 'metrics' parameter has a default value of None but is annotated with Dict[str, int]. Consider updating the type hint to Optional[Dict[str, int]] or using an empty dict as the default to avoid potential type issues.
Copilot uses AI. Check for mistakes.
|
API change check API changes are not detected in this pull request. |
…nts.py Co-authored-by: Copilot <[email protected]>
w-javed
approved these changes
Apr 25, 2025
singankit
force-pushed
the
users/singankit/upload_evaluation_run_1rp
branch
from
0b696cb to
dc5a3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to upload evaluation with 1 DP Project. Not tested yet needs for evaluators working with 1 RP to validate.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines