Skip to content

[AutoRelease] t2-search-2025-04-27-45644(can only be merged by SDK owner) #40747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

https://github.com/Azure/sdk-release-request/issues/6107
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1027
BuildTargetingString
azure-mgmt-search
Skip.CreateApiReview

@azure-sdk
Copy link
Collaborator Author

@Copilot Copilot AI review requested due to automatic review settings April 27, 2025 05:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the async operations for the Azure Search Management client by standardizing type annotations and import patterns while also removing the now‐unused OfferingsOperations module. Key changes include replacing deprecated sys version conditional imports with collections.abc usage, adding explicit type annotations for client configuration and serializer/deserializer instances, and updating default API version values and documentation.

Reviewed Changes

Copilot reviewed 107 out of 108 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_query_keys_operations.py Updated imports and added type annotations in the init method.
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_private_link_resources_operations.py Similar updates with import replacements and added type annotations.
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_private_endpoint_connections_operations.py Replaced sys blocks and introduced type annotations.
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_operations.py Removed redundant sys version checks and added type annotations.
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_offerings_operations.py Removed the OfferingsOperations module.
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_network_security_perimeter_configurations_operations.py Updated parameter descriptions to reflect “network security perimeter configuration” naming.
sdk/search/azure-mgmt-search/azure/mgmt/search/init.py Removed OfferingsOperations from the exports.
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/_search_management_client.py Updated client initialization with new default API version and removed OfferingsOperations property.
sdk/search/azure-mgmt-search/azure/mgmt/search/_version.py, _configuration.py, README.md, CHANGELOG.md Updated version information, default API version, and Python version requirements.
Files not reviewed (1)
  • sdk/search/azure-mgmt-search/_meta.json: Language not supported
Comments suppressed due to low confidence (2)

sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/init.py:16

  • OfferingsOperations has been removed from the exports. Please ensure that any documentation or test cases referencing this module are updated accordingly.
from ._offerings_operations import OfferingsOperations  # type: ignore

sdk/search/azure-mgmt-search/azure/mgmt/search/aio/_search_management_client.py:118

  • The offerings property has been removed from the client initialization. Verify that all consumers and related documentation are updated to account for the removal.
self.offerings = OfferingsOperations(self._client, self._config, self._serialize, self._deserialize)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants