[tsp-client] test fixes #13027
Merged
[tsp-client] test fixes #13027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates test assets and improves test code in the tsp-client tool. The main changes include updating TypeSpec and related package dependencies from version 0.38.x/0.67.x to 0.46.x/1.6.x, cleaning up redundant repoRoot variable assignments in tests, and combining/simplifying test cases. Three tests were skipped with a tracking issue created for investigation.
Key changes:
- Dependency version updates across multiple test fixture files
- Test cleanup improvements with
afterEachhook - Test case consolidation (combining "Sync" and "Generate" tests)
- Removal of redundant
repoRootvariable assignments
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/tsp-client/test/utils/*.json | Updated TypeSpec dependency versions in test fixture files |
| tools/tsp-client/test/commands.spec.ts | Added afterEach cleanup, consolidated tests, removed redundant repoRoot assignments |
| tools/tsp-client/test/examples/specification/*/main.tsp | Removed @useDependency decorators |
| tools/tsp-client/test/examples/specification/*/tspconfig.yaml | Updated emitter configuration options |
| tools/tsp-client/test/examples/package.json | Updated dependency versions and added missing packages |
| tools/tsp-client/test/examples/sdk/*/tsp-location.yaml | Updated commit hash reference |
Files not reviewed (2)
- tools/tsp-client/test/utils/alternate-emitter-package-lock.json: Language not supported
- tools/tsp-client/test/utils/emitter-package-lock.json: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
timotheeguerin
approved these changes
Nov 21, 2025
Member
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incudes:
Tracking issue to investigate the 3 tests that were skipped: #13033