Included group id for java library when create api view #13038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for including the Java groupId when constructing package names for API view creation, addressing issue #12506. The implementation ensures that Java packages are properly identified with their full Maven coordinates (groupId:artifactId format).
- Adds logic to construct full package name with groupId prefix for Java libraries
- Includes helpful documentation comments showing PackageInfoFiles parameter format
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Detect-Api-Changes.ps1 | Adds groupId prefix to package artifact name when Group property is available, following the Maven coordinate pattern used in Validate-All-Packages.ps1 |
| eng/common/pipelines/templates/steps/validate-all-packages.yml | Adds documentation comment showing example format for PackageInfoFiles parameter |
| eng/common/pipelines/templates/steps/create-apireview.yml | Adds documentation comment showing example format for PackageInfoFiles parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12506