Sync eng/common directory with azure-sdk-tools for PR 13005 #9421
Conversation
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the eng/common directory with azure-sdk-tools PR 13005, adding support for tracking TypeSpec project paths in Azure DevOps work items. The changes enable the build system to read tsp-location.yaml files from package directories and propagate the spec project path information to DevOps work items for better tracking and integration with the azure-rest-api-specs repository.
Key Changes:
- Added
SpecProjectPathproperty to thePackagePropsclass that reads fromtsp-location.yamlfiles - Updated DevOps work item creation and updates to include the
Custom.SpecProjectPathfield - Added logging output for the spec project path during package property processing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Package-Properties.ps1 | Adds SpecProjectPath property to PackageProps class and reads from tsp-location.yaml |
| eng/common/scripts/Save-Package-Properties.ps1 | Adds console output for the spec project path during package processing |
| eng/common/scripts/Validate-All-Packages.ps1 | Passes SpecProjectPath parameter to work item creation function |
| eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 | Updates work item functions to support Custom.SpecProjectPath field in queries, creation, and updates |
| if ($pkgType -ne [string]$existingItem.fields["Custom.PackageType"]) { $changedField = "Custom.PackageType" } | ||
| if ($pkgNewLibrary -ne $existingItem.fields["Custom.PackageTypeNewLibrary"]) { $changedField = "Custom.PackageTypeNewLibrary" } | ||
| if ($pkgRepoPath -ne $existingItem.fields["Custom.PackageRepoPath"]) { $changedField = "Custom.PackageRepoPath" } | ||
| if ($serviceName -ne $existingItem.fields["Custom.ServiceName"]) { $changedField = "Custom.ServiceName" } |
There was a problem hiding this comment.
The removed check for title changes could mask important updates. If the title changes, the work item should be updated to reflect the new title. Consider adding back the title check or document why title changes should not trigger updates.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13005 See eng/common workflow