add desired capabilities to sender and amqp short type #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
requested review from
annatisch,
swathipil,
lmazuel and
rakshith91
annatisch
approved these changes
Feb 24, 2021
| :param desired_capabilities: The extension capabilities desired from the peer endpoint. | ||
| To create a desired_capabilities object, please do as follows: | ||
| - 1. Create an array of desired capability symbols: `capabilities_symbol_array = [types.AMQPSymbol(string)]` | ||
| - 2. Transform the array to AMQPValue object: `utils.data_factory(types.AMQPArray(capabilities_symbol_array))` |
There was a problem hiding this comment.
Not blocking right now - but could we not automatically perform this transformation if someone passes in a list of strings?
So type could be Union[AMQPValue, List[str]]
There was a problem hiding this comment.
yea, I think that should be doable and would be nice to have.
I have created a separate issue for this one: #212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the missing desired capability and short type which is required by the EH idempotent feature: Azure/azure-sdk-for-python#12427