Skip to content

Commit

Permalink
Merge branch 'main' into carocao/micAPI
Browse files Browse the repository at this point in the history
  • Loading branch information
carocao-msft authored Feb 28, 2025
2 parents 8af5596 + 8fea7e8 commit 9a14a56
Show file tree
Hide file tree
Showing 68 changed files with 827 additions and 280 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y",
"comment": "Update aria-level for heading on the config screen",
"workstream": "VideoGallery",
"comment": "Update styles for screenshare loading spinner to better handle long names on mobile and desktop",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"type": "patch",
"type": "minor",
"area": "fix",
"workstream": "CallAdapter",
"comment": "Update the Max number of event listeners on a event in the CallAdapter",
"workstream": "Error handling",
"comment": "Add code and subcode to calling errors to help with debugging",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y",
"comment": "Fix control bar button and more button A11y issues, announcing collapsed and expanded state",
"workstream": "Fix bug where microphone error shows twice",
"comment": "Fix bug where microphone error shows twice",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y",
"comment": "Update configuration screen to support use at 400% zoom",
"workstream": "VideoGallery",
"comment": "Update styles for screenshare loading spinner to better handle long names on mobile and desktop",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "fix",
"workstream": "Error handling",
"comment": "Add code and subcode to calling errors to help with debugging",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"type": "patch",
"area": "feature",
"workstream": "Captions",
"comment": "Fix bug where spoken and caption language drawer missing default value",
"area": "fix",
"workstream": "Fix bug where microphone error shows twice",
"comment": "Fix bug where microphone error shows twice",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
Expand Down
2 changes: 1 addition & 1 deletion packages/acs-ui-common/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internal/acs-ui-common",
"version": "1.25.0-beta.0",
"version": "1.25.0-beta.1",
"description": "Common types and utilities for all Azure Communication Serves UI libraries",
"module": "dist/dist-esm/index.js",
"main": "dist/dist-cjs/index.js",
Expand Down
21 changes: 21 additions & 0 deletions packages/acs-ui-javascript-loaders/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,27 @@
{
"name": "@internal/acs-ui-javascript-loaders",
"entries": [
{
"date": "Mon, 24 Feb 2025 23:41:48 GMT",
"version": "1.25.0-beta.1",
"tag": "@internal/acs-ui-javascript-loaders_v1.25.0-beta.1",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@internal/acs-ui-javascript-loaders",
"comment": "Bump @internal/acs-ui-common to v1.25.0-beta.1",
"commit": "not available"
},
{
"author": "beachball",
"package": "@internal/acs-ui-javascript-loaders",
"comment": "Bump @internal/react-composites to v1.25.0-beta.1",
"commit": "not available"
}
]
}
},
{
"date": "Mon, 10 Feb 2025 18:17:46 GMT",
"version": "1.24.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/acs-ui-javascript-loaders/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internal/acs-ui-javascript-loaders",
"version": "1.25.0-beta.0",
"version": "1.25.0-beta.1",
"description": "Component bindings specific to components that integrate with the Azure Communication Services Calling JavaScript SDK",
"module": "dist/dist-esm/index.js",
"main": "dist/dist-cjs/index.js",
Expand Down Expand Up @@ -32,8 +32,8 @@
"license": "ISC",
"dependencies": {
"@azure/communication-common": "^2.3.1",
"@internal/acs-ui-common": "1.25.0-beta.0",
"@internal/react-composites": "1.25.0-beta.0",
"@internal/acs-ui-common": "1.25.0-beta.1",
"@internal/react-composites": "1.25.0-beta.1",
"@fluentui/react": "^8.122.9",
"@azure/logger": "^1.0.4"
},
Expand Down
27 changes: 27 additions & 0 deletions packages/calling-component-bindings/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,33 @@
{
"name": "@internal/calling-component-bindings",
"entries": [
{
"date": "Mon, 24 Feb 2025 23:41:48 GMT",
"version": "1.25.0-beta.1",
"tag": "@internal/calling-component-bindings_v1.25.0-beta.1",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@internal/calling-component-bindings",
"comment": "Bump @internal/acs-ui-common to v1.25.0-beta.1",
"commit": "not available"
},
{
"author": "beachball",
"package": "@internal/calling-component-bindings",
"comment": "Bump @internal/calling-stateful-client to v1.25.0-beta.1",
"commit": "not available"
},
{
"author": "beachball",
"package": "@internal/calling-component-bindings",
"comment": "Bump @internal/react-components to v1.25.0-beta.1",
"commit": "not available"
}
]
}
},
{
"date": "Mon, 10 Feb 2025 18:17:46 GMT",
"version": "1.24.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/calling-component-bindings/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internal/calling-component-bindings",
"version": "1.25.0-beta.0",
"version": "1.25.0-beta.1",
"description": "Component bindings specific to components that integrate with the Azure Communication Services Calling JavaScript SDK",
"module": "dist/dist-esm/index.js",
"main": "dist/dist-cjs/index.js",
Expand Down Expand Up @@ -31,9 +31,9 @@
},
"license": "MIT",
"dependencies": {
"@internal/acs-ui-common": "1.25.0-beta.0",
"@internal/calling-stateful-client": "1.25.0-beta.0",
"@internal/react-components": "1.25.0-beta.0",
"@internal/acs-ui-common": "1.25.0-beta.1",
"@internal/calling-stateful-client": "1.25.0-beta.1",
"@internal/react-components": "1.25.0-beta.1",
"@azure/communication-common": "^2.3.1",
"memoize-one": "^5.2.1",
"reselect": "^4.0.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/calling-component-bindings/src/errorBarSelector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ export const errorBarSelector: ErrorBarSelector = createSelector(
if (deviceManager.deviceAccess?.audio === false && isSafari()) {
activeErrorMessages.push({ type: 'callMicrophoneAccessDeniedSafari' });
}
if (deviceManager.deviceAccess?.audio === false && !isSafari()) {
activeErrorMessages.push({ type: 'callMicrophoneAccessDenied' });
}

if (diagnostics?.media.latest.microphonePermissionDenied?.value === true && isMacOS()) {
activeErrorMessages.push({ type: 'callMacOsMicrophoneAccessDenied' });
} else if (diagnostics?.media.latest.microphonePermissionDenied?.value === true) {
} else if (
(deviceManager.deviceAccess?.audio === false && !isSafari()) ||
(diagnostics?.media.latest.microphonePermissionDenied?.value === true && !isMacOS())
) {
activeErrorMessages.push({ type: 'callMicrophoneAccessDenied' });
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ export const notificationStackSelector: NotificationStackSelector = createSelect
if (deviceManager.deviceAccess?.audio === false && isSafari()) {
activeErrorMessages.push({ type: 'callMicrophoneAccessDeniedSafari' });
}
if (deviceManager.deviceAccess?.audio === false && !isSafari()) {
activeErrorMessages.push({ type: 'callMicrophoneAccessDenied' });
}

if (diagnostics?.media.latest.microphonePermissionDenied?.value === true && isMacOS()) {
activeErrorMessages.push({ type: 'callMacOsMicrophoneAccessDenied' });
} else if (diagnostics?.media.latest.microphonePermissionDenied?.value === true) {
} else if (
(deviceManager.deviceAccess?.audio === false && !isSafari()) ||
(diagnostics?.media.latest.microphonePermissionDenied?.value === true && !isMacOS())
) {
activeErrorMessages.push({ type: 'callMicrophoneAccessDenied' });
}

Expand Down
15 changes: 15 additions & 0 deletions packages/calling-stateful-client/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@internal/calling-stateful-client",
"entries": [
{
"date": "Mon, 24 Feb 2025 23:41:48 GMT",
"version": "1.25.0-beta.1",
"tag": "@internal/calling-stateful-client_v1.25.0-beta.1",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@internal/calling-stateful-client",
"comment": "Bump @internal/acs-ui-common to v1.25.0-beta.1",
"commit": "not available"
}
]
}
},
{
"date": "Mon, 10 Feb 2025 18:17:46 GMT",
"version": "1.24.0",
Expand Down
Loading

0 comments on commit 9a14a56

Please sign in to comment.