Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix naming bump type in pre-release #4732

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dmceachernmsft
Copy link
Member

What

Updates action to fix bump type

Why

bad input retrieval so sad branch name

https://skype.visualstudio.com/SPOOL/_workitems/edit/3761635

How Tested

Ran action on branch

Copy link
Contributor

Calling bundle size is decreased✅.

  • Current size: 5020811
  • Base size: 5020812
  • Diff size: -1

Copy link
Contributor

CallWithChat bundle size is decreased✅.

  • Current size: 6377544
  • Base size: 6377545
  • Diff size: -1

Copy link
Contributor

Chat bundle size is decreased✅.

  • Current size: 2096016
  • Base size: 2096017
  • Diff size: -1

Copy link
Member

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will sanity check on Monday,....

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26158 / 40963
63.85%
26158 / 40963
63.85%
717 / 1281
55.97%
2113 / 3345
63.16%
Current 26075 / 40963
63.65%
26075 / 40963
63.65%
717 / 1281
55.97%
2090 / 3332
62.72%
Diff -83 / 0
-0.2%
-83 / 0
-0.2%
0 / 0
0%
-23 / -13
-0.44%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50782 / 81886
62.01%
50782 / 81886
62.01%
1037 / 2311
44.87%
3001 / 4918
61.02%
Current 50786 / 81886
62.02%
50786 / 81886
62.02%
1037 / 2311
44.87%
2997 / 4910
61.03%
Diff 4 / 0
0.01%
4 / 0
0.01%
0 / 0
0%
-4 / -8
0.01%

@dmceachernmsft dmceachernmsft merged commit d1ae439 into main Jun 14, 2024
41 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/release-bump-type-fix branch June 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants