Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random eslint errors #5289

Merged
merged 16 commits into from
Oct 10, 2024
Merged

Fix random eslint errors #5289

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
96fcc2a
lint fix
carocao-msft Oct 9, 2024
5f9fa15
[JS-loaders] Conceptual docs (#5202)
dmceachernmsft Oct 9, 2024
435541e
Dependency updates (#5285)
emlynmac Oct 9, 2024
0950e00
[A11y bugfix] Make reactions button Keyboard accessible (#5281)
dmceachernmsft Oct 9, 2024
c5bd225
lint fix
carocao-msft Oct 9, 2024
37c1167
Merge branch 'main' into carocao/lint
carocao-msft Oct 9, 2024
da2e94d
lint
carocao-msft Oct 9, 2024
2538f77
lock file
carocao-msft Oct 9, 2024
548a6e4
Merge branch 'main' into carocao/lint
carocao-msft Oct 9, 2024
8c75ba8
main
carocao-msft Oct 9, 2024
af80d6f
lock change
carocao-msft Oct 9, 2024
234caf8
lock file
carocao-msft Oct 9, 2024
dec1752
lock
carocao-msft Oct 9, 2024
004b268
pr comment
carocao-msft Oct 10, 2024
2209d04
Merge branch 'main' into carocao/lint
carocao-msft Oct 10, 2024
0d9d7fc
Merge branch 'main' into carocao/lint
carocao-msft Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 52 additions & 22 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

74 changes: 52 additions & 22 deletions common/config/rush/variants/stable/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion packages/acs-ui-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@
"rimraf": "^2.6.2",
"rollup": "^4.21.2",
"ts-jest": "^29.1.5",
"typescript": "5.4.5"
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
Copy link
Member

@JamesBurnside JamesBurnside Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Suggestion, non-blocking) Could this instead be in the common-versions files? Just that it would allow the change to be kept to one file and, more importantly, allow a comment why it's been added. (otherwise someone will need to git blame and look up this PR to understand why this is present in the package.json)

"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/acs-ui-javascript-loaders/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@
"rimraf": "^2.6.2",
"rollup": "^4.21.2",
"ts-jest": "^29.1.5",
"typescript": "5.4.5"
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/calling-component-bindings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@
"rimraf": "^2.6.2",
"rollup": "^4.21.2",
"ts-jest": "^29.1.5",
"typescript": "5.4.5"
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/calling-stateful-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@
"rimraf": "^2.6.2",
"rollup": "^4.21.2",
"ts-jest": "^29.1.5",
"typescript": "5.4.5"
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/chat-component-bindings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@
"react": "18.3.1",
"rimraf": "^2.6.2",
"rollup": "^4.21.2",
"typescript": "5.4.5"
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/chat-stateful-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@
"rimraf": "^2.6.2",
"rollup": "^4.21.2",
"ts-jest": "^29.1.5",
"typescript": "5.4.5"
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/communication-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,15 @@
"ts-patch": "^3.1.2",
"type-fest": "^4.14.0",
"typescript": "5.4.5",
"typescript-transform-paths": "^3.4.7"
"typescript-transform-paths": "^3.4.7",
"synckit": "0.8.8"
},
"beachball": {
"shouldPublish": false
},
"overrides": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything in this package.json gets published to our npm package, can you add to here:

communication-ui-library/common/scripts/prepare-package-json.js

Line 15 in 8f6ab24

delete result.beachball;
a delete of this overrides section

"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/fake-backends/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@
"rollup": "^4.21.2",
"ts-jest": "^29.1.5",
"typescript": "5.4.5",
"webpack": "5.95.0"
"webpack": "5.95.0",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@
"ts-node": "^10.9.2",
"type-fest": "^4.14.0",
"typescript": "5.4.5",
"webpack": "5.95.0"
"webpack": "5.95.0",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/react-composites/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,12 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.2",
"webpack": "5.95.0",
"yargs": "^17.7.2"
"yargs": "^17.7.2",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion packages/storybook8/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@
"ts-loader": "^8.0.12",
"ts-node": "^10.9.2",
"typescript": "5.4.5",
"webpack": "5.95.0"
"webpack": "5.95.0",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion samples/CallWithChat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.2",
"webpack-bundle-analyzer": "^4.5.0",
"@babel/cli": "^7.24.8"
"@babel/cli": "^7.24.8",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion samples/Calling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.2",
"webpack": "5.95.0",
"webpack-bundle-analyzer": "^4.5.0"
"webpack-bundle-analyzer": "^4.5.0",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion samples/CallingStateful/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.2",
"webpack": "5.95.0",
"webpack-bundle-analyzer": "^4.5.0"
"webpack-bundle-analyzer": "^4.5.0",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion samples/Chat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@
"webpack-dev-server": "4.15.2",
"webpack": "5.95.0",
"webpack-bundle-analyzer": "^4.5.0",
"@babel/cli": "^7.24.8"
"@babel/cli": "^7.24.8",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion samples/ComponentExamples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@
"typescript": "5.4.5",
"webpack": "5.95.0",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.2"
"webpack-dev-server": "4.15.2",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion samples/Server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@
"typescript": "5.4.5",
"webpack": "5.95.0",
"webpack-cli": "^5.1.4",
"webpack-node-externals": "^3.0.0"
"webpack-node-externals": "^3.0.0",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion tools/check-treeshaking/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
"prettier": "3.3.2",
"rimraf": "^2.6.2",
"webpack": "5.95.0",
"webpack-cli": "^5.1.4"
"webpack-cli": "^5.1.4",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
8 changes: 7 additions & 1 deletion tools/check-typescript-regression/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@
"eslint-plugin-import": "^2.31.0",
"prettier": "3.3.2",
"rimraf": "^2.6.2",
"typescript": "4.6.3"
"typescript": "4.6.3",
"synckit": "0.8.8"
},
"overrides": {
"eslint-plugin-prettier": {
"synckit": "0.8.8"
}
}
}
Loading