Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prerelease stable remove beta suffix/1.23.0 #5548

Merged
merged 11 commits into from
Jan 24, 2025
Merged

Prerelease stable remove beta suffix/1.23.0 #5548

merged 11 commits into from
Jan 24, 2025

Conversation

carocao-msft
Copy link
Contributor

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft requested review from a team as code owners January 13, 2025 19:45
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-oyythgwusm.chromatic.com/

@carocao-msft @github-actions
Create groom me file for groom changelog branch (#5549)
a162ad7 
* Create groom me file for groom changelog branch

* groomc

* update

* Update CHANGELOG to consolidate PR referencesupdate

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-emhadubrcy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zzumhzimxv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-srnyrhwhaa.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zttwvgsfbs.chromatic.com/

@carocao-msft carocao-msft enabled auto-merge (squash) January 24, 2025 22:15
@carocao-msft carocao-msft disabled auto-merge January 24, 2025 22:53
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-udjppfaafq.chromatic.com/

@carocao-msft carocao-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1783839
  • Base size: 1783838
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-phmyeknvcl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27942 / 44356
62.99%		 27942 / 44356
62.99%		 783 / 1424
54.98%		 2354 / 3724
63.21%
Current 27936 / 44356
62.98%		 27936 / 44356
62.98%		 783 / 1424
54.98%		 2322 / 3702
62.72%
Diff -6 / 0
-0.01%		 -6 / 0
-0.01%		 0 / 0
0%		 -32 / -22
-0.49%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56799 / 93591
60.68%		 56799 / 93591
60.68%		 1157 / 2670
43.33%		 3465 / 5712
60.66%
Current 56867 / 93591
60.76%		 56867 / 93591
60.76%		 1157 / 2670
43.33%		 3465 / 5720
60.57%
Diff 68 / 0
0.08%		 68 / 0
0.08%		 0 / 0
0%		 0 / 8
-0.09%

@carocao-msft carocao-msft merged commit 3593324 into main Jan 24, 2025
41 checks passed
@carocao-msft carocao-msft deleted the prerelease-stable-remove-beta-suffix/1.23.0 branch January 24, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

Assignees
No one assigned
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carocao-msft @dmceachernmsft @Leah-Xia-Microsoft @fuyan2024