Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated together mode condirtional compile #5552

Closed
wants to merge 3 commits into from

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Jan 13, 2025

What

Updated together mode conditional compile

Why

Needed to ensure together mode does not show up in stable

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1768953
  • Base size: 1768952
  • Diff size: 1

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

Copy link
Contributor

@cn0151 cn0151 closed this Jan 13, 2025
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27842 / 44291
62.86%
27842 / 44291
62.86%
782 / 1422
54.99%
2319 / 3688
62.87%
Current 27895 / 44291
62.98%
27895 / 44291
62.98%
782 / 1422
54.99%
2339 / 3706
63.11%
Diff 53 / 0
0.12%
53 / 0
0.12%
0 / 0
0%
20 / 18
0.24%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56693 / 93264
60.78%
56693 / 93264
60.78%
1156 / 2667
43.34%
3403 / 5677
59.94%
Current 56794 / 93265
60.89%
56794 / 93265
60.89%
1156 / 2667
43.34%
3501 / 5736
61.03%
Diff 101 / 1
0.11%
101 / 1
0.11%
0 / 0
0%
98 / 59
1.09%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants