Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code logic #5568

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Cleanup code logic #5568

merged 3 commits into from
Jan 23, 2025

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Jan 17, 2025

What

The changes in this PR includes the following

  • calling the SDK start api is now idempotent so need to check if together mode is active or not
  • Remove redundant code check for screen sharing when together mode is active
  • Memoize together mode properties in the video gallery utils

Why

Needed as part of together mode integration into web ui

How Tested

locally

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1783692
  • Base size: 1783692
  • Diff size: 0

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27886 / 44346
62.88%
27886 / 44346
62.88%
783 / 1424
54.98%
2358 / 3718
63.42%
Current 27942 / 44356
62.99%
27942 / 44356
62.99%
783 / 1424
54.98%
2326 / 3704
62.79%
Diff 56 / 10
0.11%
56 / 10
0.11%
0 / 0
0%
-32 / -14
-0.63%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56810 / 93531
60.73%
56810 / 93531
60.73%
1157 / 2670
43.33%
3508 / 5737
61.14%
Current 56811 / 93577
60.71%
56811 / 93577
60.71%
1157 / 2670
43.33%
3433 / 5696
60.27%
Diff 1 / 46
-0.02%
1 / 46
-0.02%
0 / 0
0%
-75 / -41
-0.87%

@cn0151 cn0151 merged commit 47e7280 into main Jan 23, 2025
41 checks passed
@cn0151 cn0151 deleted the cnwankwo/together_ui_impl branch January 23, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants