Real Time Text API update and tests #5580
Conversation
carocao-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dsgaemqvjv.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fllhlolczo.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ndkmxrurpu.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ujonbhgrjh.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xxqsqxpndn.chromatic.com/ |
| @@ -227,7 +228,7 @@ export const CaptionsBanner = (props: CaptionsBannerProps): JSX.Element => { | |||
|
|
|||
| /* @conditional-compile-remove(rtt) */ | |||
| const mergedCaptions: (CaptionsInformation | RealTimeTextInformation)[] = useMemo(() => { | |||
| return [...combinedList, ...(realTimeTexts?.currentInProgress ?? []), realTimeTexts?.myInProgress] as ( | |||
| return [...combinedList, ...(realTimeTexts?.currentInProgress ?? []), realTimeTexts?.myInProgress].slice(-50) as ( | |||
There was a problem hiding this comment.
Does mean that inprogress captions counts towards the 50?
| @@ -351,6 +345,13 @@ export const CaptionsBanner = (props: CaptionsBannerProps): JSX.Element => { | |||
| } | |||
| data-ui-id="captions-banner-inner" | |||
| > | |||
| { | |||
| /* @conditional-compile-remove(rtt) */ isRealTimeTextOn && ( | |||
| <div style={{ paddingTop: '0.5rem' }}> | |||
There was a problem hiding this comment.
Since this is a component, should we extract this style to a style?
Should this be a stack?
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yxrtfizmyp.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-muchhjjgrp.chromatic.com/ |
Calling bundle size is not changed.
|
Chat bundle size is decreased✅.
|
CallWithChat bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kylnmbrrxf.chromatic.com/ |
What
Caption Banner API update, and update the merged caption list to only store 50 entries. Also added tests for the sorting logic
Why
How Tested
Process & policy checklist
Is this a breaking change?