Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose onRenderAvatar api to all the composites #5662

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Expose onRenderAvatar api to all the composites #5662

wants to merge 7 commits into from
+377 −60

Conversation

Leah-Xia-Microsoft
Copy link
Member

@Leah-Xia-Microsoft Leah-Xia-Microsoft commented Feb 24, 2025 •
edited
Loading

What

Expose onRenderAvatar api to all the composites

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-picnhcrgrh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27998 / 44676
62.66%		 27998 / 44676
62.66%		 786 / 1436
54.73%		 2352 / 3718
63.25%
Current 28005 / 44683
62.67%		 28005 / 44683
62.67%		 786 / 1436
54.73%		 2354 / 3720
63.27%
Diff 7 / 7
0.01%		 7 / 7
0.01%		 0 / 0
0%		 2 / 2
0.02%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58248 / 94221
61.82%		 58248 / 94221
61.82%		 1177 / 2693
43.7%		 3528 / 5820
60.61%
Current 58384 / 94466
61.8%		 58384 / 94466
61.8%		 1177 / 2693
43.7%		 3510 / 5818
60.33%
Diff 136 / 245
-0.02%		 136 / 245
-0.02%		 0 / 0
0%		 -18 / -2
-0.28%

@Leah-Xia-Microsoft Leah-Xia-Microsoft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 25, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-cgexncssqh.chromatic.com/

@Leah-Xia-Microsoft Leah-Xia-Microsoft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 25, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1777642
  • Base size: 1777282
  • Diff size: 360

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rnvrugghcr.chromatic.com/

@Leah-Xia-Microsoft Leah-Xia-Microsoft marked this pull request as ready for review February 25, 2025 17:55
@Leah-Xia-Microsoft Leah-Xia-Microsoft requested review from a team as code owners February 25, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees

@dmceachernmsft dmceachernmsft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leah-Xia-Microsoft @dmceachernmsft