Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat composite snapshot #5667

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

Leah-Xia-Microsoft
Copy link
Member

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@Leah-Xia-Microsoft Leah-Xia-Microsoft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Feb 26, 2025
Copy link
Contributor

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27998 / 44676
62.66%
27998 / 44676
62.66%
786 / 1436
54.73%
2352 / 3718
63.25%
Current 28058 / 44676
62.8%
28058 / 44676
62.8%
786 / 1436
54.73%
2352 / 3722
63.19%
Diff 60 / 0
0.14%
60 / 0
0.14%
0 / 0
0%
0 / 4
-0.06%

Copy link
Contributor

github-actions bot commented Feb 26, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58248 / 94221
61.82%
58248 / 94221
61.82%
1177 / 2693
43.7%
3528 / 5820
60.61%
Current 58225 / 94221
61.79%
58225 / 94221
61.79%
1177 / 2693
43.7%
3503 / 5806
60.33%
Diff -23 / 0
-0.03%
-23 / 0
-0.03%
0 / 0
0%
-25 / -14
-0.28%

Copy link
Contributor

Chat bundle size is decreased✅.

  • Current size: 1777281
  • Base size: 1777282
  • Diff size: -1

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@Leah-Xia-Microsoft Leah-Xia-Microsoft merged commit 26cea71 into main Feb 26, 2025
40 checks passed
@Leah-Xia-Microsoft Leah-Xia-Microsoft deleted the leahxia/fix-chat-composite-snapshot branch February 26, 2025 20:04
Leah-Xia-Microsoft added a commit that referenced this pull request Feb 26, 2025
dmceachernmsft pushed a commit that referenced this pull request Feb 27, 2025
* Update embed html bundle snapshots

* Update packages/react-composites CallComposite browser test snapshots

* Fix chat composite snapshot (#5667) (#5669)

* Update embed html bundle snapshots

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Leah Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants