[bugfix] add code and subcode to callError #5672
Conversation
dmceachernmsft
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wqyjsfniak.chromatic.com/ |
There was a problem hiding this comment.
PR Overview
The PR adds error code and subCode properties to the CallError class to better propagate error details from the calling service. It also updates the API definitions in both beta and stable releases and adds an error event listener in the sample application.
Reviewed Changes
| File | Description |
|---|---|
| packages/calling-stateful-client/src/CallClientState.ts | Extends CallError to extract and expose code and subCode from CommunicationServicesError |
| packages/communication-react/review/beta/communication-react.api.md | Updates CallError API to include code and subCode properties |
| packages/communication-react/review/stable/communication-react.api.md | Updates CallError API to include code and subCode properties |
| samples/Calling/src/app/views/CallScreen.tsx | Adds an error event listener for logging adapter errors |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-amzldawcdr.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
| */ | ||
| if (this.callId === latestEndedCall?.id) { | ||
| this.emitter.emit('callEnded', { | ||
| callId: latestEndedCall?.id, |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xirdgsprte.chromatic.com/ |
…Azure/communication-ui-library into dmceachernmsft/onError-code-sub
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zldozotixr.chromatic.com/ |
|
Breaking change check is added as the selector hook is impacted by the CallError change |
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Chat bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qylklyzlao.chromatic.com/ |
What
Add code and cubcode to the calling error
Why
Calling provides a series of codes and subcodes to help customers debug what happened when a error occurs so we are proxying them up through our errors as well
https://skype.visualstudio.com/SPOOL/_workitems/edit/3999557
How Tested
Validated locally
