Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Breakout rooms storybook page #5674

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

mgamis-msft
Copy link
Contributor

What

Cherry pick #5274 to release/1.25.0-beta.1

Why

Ensure storybook has latest content for breakout rooms feature

How Tested

Tested locally. We can also rely on generated chromatic in this PR

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

* Add breakout rooms page to storybook

* Remove breakout rooms from storybook 6

* Update breakout rooms storybook doc and remove section for incorporation to component-only apps

* minor edits
@mgamis-msft mgamis-msft requested review from a team as code owners February 27, 2025 18:32
@mgamis-msft mgamis-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Feb 27, 2025
Copy link
Contributor

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

2 similar comments
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

@mgamis-msft mgamis-msft merged commit 213569e into release/1.25.0-beta.1 Feb 27, 2025
21 of 22 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/cherry-pick-5274 branch February 27, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants