[Bugfix] long name screenshare mobile fix #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmceachernmsft
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mdhfkcjzeh.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xrzvqwktcs.chromatic.com/ |
mgamis-msft
approved these changes
Feb 28, 2025
…/github.com/Azure/communication-ui-library into dmceachernmsft/long-name-screenshare-mobile
carocao-msft
approved these changes
Feb 28, 2025
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gvmlpzdjys.chromatic.com/ |
CallWithChat bundle size is not changed.
|
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jshribyfdb.chromatic.com/ |
dmceachernmsft
deleted the
dmceachernmsft/long-name-screenshare-mobile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the styling of the spinner on the screenshare component to handle long names better
Why
Stops the length of the name causing weird rendering issues in the composite and components when someone has a really long name from causing scroll bars
https://skype.visualstudio.com/SPOOL/_workitems/edit/4050420
How Tested
Tested locally