Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Express to v5 #5682

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Update Express to v5 #5682

merged 3 commits into from
Mar 5, 2025

Conversation

palatter
Copy link
Member

@palatter palatter commented Mar 4, 2025

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@palatter palatter requested review from a team as code owners March 4, 2025 20:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-obpfkraadm.chromatic.com/

@palatter palatter added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Mar 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gekfwkmmnb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28023 / 44693
62.7%		 28023 / 44693
62.7%		 786 / 1436
54.73%		 2353 / 3720
63.25%
Current 28023 / 44693
62.7%		 28023 / 44693
62.7%		 786 / 1436
54.73%		 2353 / 3720
63.25%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 0 / 0
0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58244 / 94260
61.79%		 58244 / 94260
61.79%		 1177 / 2693
43.7%		 3531 / 5822
60.64%
Current 58223 / 94260
61.76%		 58223 / 94260
61.76%		 1177 / 2693
43.7%		 3511 / 5810
60.43%
Diff -21 / 0
-0.03%		 -21 / 0
-0.03%		 0 / 0
0%		 -20 / -12
-0.21%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Chat bundle size is increased❗.

  • Current size: 1777648
  • Base size: 1777647
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dixeicrkyk.chromatic.com/

@palatter palatter merged commit 1a36ba3 into main Mar 5, 2025
41 checks passed
@palatter palatter deleted the palatter/express-update branch March 5, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@JoshuaLai JoshuaLai JoshuaLai approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palatter @emlynmac @JoshuaLai