Skip to content

Conversation

@mgamis-msft
Copy link
Contributor

@mgamis-msft mgamis-msft commented Nov 25, 2025

What

Added right padding and wrapping text for Prompt title

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/4310934

How Tested

Tested locally
image

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29739 / 47381
62.76%
29739 / 47381
62.76%
810 / 1491
54.32%
2394 / 3842
62.31%
Current 29745 / 47383
62.77%
29745 / 47383
62.77%
810 / 1491
54.32%
2415 / 3853
62.67%
Diff 6 / 2
0.01%
6 / 2
0.01%
0 / 0
0%
21 / 11
0.36%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58580 / 95109
61.59%
58580 / 95109
61.59%
1180 / 2709
43.55%
3417 / 5799
58.92%
Current 58590 / 95117
61.59%
58590 / 95117
61.59%
1180 / 2709
43.55%
3419 / 5800
58.94%
Diff 10 / 8
0%
10 / 8
0%
0 / 0
0%
2 / 1
0.02%

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an accessibility issue where the prompt component's heading text could overlap with the close button in the top-right corner. The fix adds right padding and text wrapping to ensure proper spacing and display.

  • Added paddingRight: '2rem' to create space for the close button
  • Added wordWrap: 'break-word' to wrap long heading text onto multiple lines

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react-composites/src/composites/CallComposite/components/Prompt.tsx Added inline styles for right padding and word wrapping to the heading Text component to prevent overlap with the close button
change/@azure-communication-react-e4ff9a18-4445-451e-88ed-1c21be5b7163.json Added changelog entry documenting the patch fix for the A11y workstream

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…nts/Prompt.tsx

Co-authored-by: Copilot <[email protected]>
Signed-off-by: mgamis-msft <[email protected]>
@github-actions
Copy link
Contributor

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 7758336 7758398 ⚠️ increased 62
450.bundle.js 4470 4470 ➖ unchanged 0
580.bundle.js 12407938 12407938 ➖ unchanged 0
727.bundle.js 372564 372564 ➖ unchanged 0
82.bundle.js 28177 28177 ➖ unchanged 0
91.bundle.js 4118 4118 ➖ unchanged 0

Total change: +62 B ⚠️

@github-actions
Copy link
Contributor

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6767681 6767743 ⚠️ increased 62
580.bundle.js 12407925 12407925 ➖ unchanged 0

Total change: +62 B ⚠️

@github-actions
Copy link
Contributor

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1793916 1793884 ⬇️ decreased -32
398.bundle.js 375829 375829 ➖ unchanged 0
450.bundle.js 4454 4454 ➖ unchanged 0
82.bundle.js 28161 28161 ➖ unchanged 0
91.bundle.js 4102 4102 ➖ unchanged 0

Total change: -32 B ⬇️

@github-actions
Copy link
Contributor

@mgamis-msft mgamis-msft merged commit bc9bed8 into main Nov 25, 2025
41 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/fix-prompt-title-overlap branch November 25, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants