Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for when on resource_action #384

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat: support for when on resource_action #384

merged 6 commits into from
Dec 12, 2023

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Dec 8, 2023 •
edited
Loading

Implements when property for azapi_resource_action

fixes #314

@matt-FFFFFF matt-FFFFFF marked this pull request as ready for review December 8, 2023 13:42
@matt-FFFFFF
Copy link
Member Author

Requesting review from @ms-henglu

ms-henglu
ms-henglu requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to work on this PR!

This PR looks good to me!

But one minor suggestion is that would you please add the new field to the doc: https://github.com/Azure/terraform-provider-azapi/blob/main/docs/resources/azapi_resource_action.md

@matt-FFFFFF
Copy link
Member Author

@ms-henglu have updated docs in 4e7c4a8

@ms-henglu ms-henglu merged commit 202c2f0 into Azure:main Dec 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-henglu ms-henglu ms-henglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource azapi_resource_action supports when=destroy
2 participants
@matt-FFFFFF @ms-henglu