Improve validation of "jku" claim (7.x)#3480
Open
alexholub113 wants to merge 2 commits into
Open
Conversation
Avery-Dunn
approved these changes
May 8, 2026
pmaytak
approved these changes
May 15, 2026
kllysng
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when validating the "jku" claim against the list from AllowedDomainsForJkuRetrieval we use Host.EndsWith for the string comparison, allowing invalid domains like "wrongcontoso.com" to bypass restrictions intended for "contoso.com"
This PR improves the validation by updating the domain matching to require either:
This is a cherry-pick of commit 6cec324 from
devtodev7x.Files changed:
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cstest/Microsoft.IdentityModel.Protocols.SignedHttpRequest.Tests/PopKeyResolvingTests.cs