Validate region string format in AADInstanceDiscovery#625
Open
bgavrilMS wants to merge 1 commit into
Open
Conversation
Add regex validation (^[a-z][a-z0-9-]*$) for the region string before it is used in URL construction. Returns a clear error if the region contains unexpected characters such as dots, slashes, or uppercase. Fixes #624 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This was referenced May 25, 2026
4gust
reviewed
May 25, 2026
| @@ -592,6 +596,9 @@ func (c Client) AADInstanceDiscovery(ctx context.Context, authorityInfo Info) (I | |||
| region = detectRegion(ctx) | |||
Collaborator
There was a problem hiding this comment.
We return error even when detected region is not valid ?
user input -> check - > pass or return error
auto detect -> check -> pass or silent fall ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #624
Problem
AADInstanceDiscoveryuses the region string directly in URL construction (https://{region}.{host}/...) without validating its format. Malformed region values containing dots, slashes, or other special characters could produce incorrect URLs.Solution
Added a regex validation (
^[a-z][a-z0-9-]*$) that checks the region string before it is used in URL construction. This matches the Azure region naming convention (e.g.,eastus,westus2,east-us-2). If the region is invalid, a clear error is returned.Changes
regexpimportvalidRegioncompiled regex at package levelAADInstanceDiscoverybefore URL interpolation