(v5) bugfix get native account

[lalimasharda]

v5 PR for the getNativeAccountId bug fix (#7960)

[Copilot]

Pull Request Overview

This PR fixes a bug in the native account retrieval logic by adding validation for empty or invalid account filters. When no login hint or SID is provided, the code now properly falls back to using the active account's native account ID instead of attempting to filter with invalid criteria.

Key changes:

• Added validation in CacheManager.getAccountInfoFilteredBy to detect and handle empty/invalid account filters
• Removed redundant filter validation from AccountManager.getAccount since it's now handled at the cache layer
• Added test coverage for the new validation logic

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
lib/msal-common/src/cache/CacheManager.ts	Added validation to return null and log a warning when account filter is empty or contains only falsy values
lib/msal-common/test/cache/CacheManager.spec.ts	Added test case verifying null is returned when filter has empty string values
lib/msal-browser/src/cache/AccountManager.ts	Removed duplicate empty filter check and simplified logging
lib/msal-browser/test/cache/BrowserCacheManager.spec.ts	Added test case verifying null is returned when filter has undefined values

[peterzenz]

This looks like it changes the behavior of the API, is this intended?

[lalimasharda]

This looks like it changes the behavior of the API, is this intended?

Yes. This change is already present in v4.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

[Copilot]

@lalimasharda I've opened a new pull request, #8420, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

@lalimasharda I've opened a new pull request, #8421, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

@lalimasharda I've opened a new pull request, #8422, to work on those changes. Once the pull request is ready, I'll request review from you.