[Feature] 사장님 가게 등록 바텀 시트 로직 적용 #540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongwoojin
reviewed
Feb 13, 2025
| colors = ButtonDefaults.buttonColors(ColorPrimary), | ||
| shape = RectangleShape, | ||
| modifier = Modifier | ||
| .height(38.dp) |
There was a problem hiding this comment.
가능하면 컴포넌트들의 크기를 하드코딩하는건 지양하는게 좋을 것 같습니다!
(일부 기기에서는 화면이 비정상적으로 출력될 수 있습니다!)
| , | ||
| horizontalArrangement = Arrangement.Center | ||
| ){ | ||
| Button( |
There was a problem hiding this comment.
같은 디자인의 버튼이 반복되네요!
별도의 composable을 만드는것도 좋을 것 같습니다!
| .width(128.dp) | ||
| ) { | ||
| Text( | ||
| text = "등록하기", |
| fun Hours.toTimeString(): String { | ||
|
|
||
| val hoursString: String = | ||
| if (this.hours < 10) "0" + this.hours.toString() else this.hours.toString() |
There was a problem hiding this comment.
String.format(null, "%02d", this.hours) 처럼 작성해도 좋을 것 같습니다!
|
|
||
| infoString = if(isClosed) "$infoString : 휴무" | ||
| else if (is24Hours) "$infoString : 24시간 운영" | ||
| else infoString + " : ${openTime} ~ ${closeTime}" |
There was a problem hiding this comment.
"$infoString : ${openTime} ~ ${closeTime}"로 스타일을 통일하는게 좋을 것 같습니다!
| ){ | ||
| Button( | ||
| onClick = nextButtonClicked, | ||
| colors = if(categoryIdIsValid)ButtonDefaults.buttonColors(ColorPrimary) else ButtonDefaults.buttonColors(ColorDisabledButton), |
There was a problem hiding this comment.
colors = ButtonDefaults.buttonColors(
backgroundColor = if (categoryIdIsValid) ColorPrimary else ColorDisabledButton
),
이게 훨씬 알아보기 쉬울 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐾 개요
🐳 상세 작업
📷 결과 화면