Feature/#458 팀장은 회원 탈퇴가 불가능하도록 구현 #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents a team leader from deleting their account by showing an error alert when the deletion request fails.
- Added response check on
deleteUserInfoto show a failure alert and close the modal ifres.okis false. - Preserves existing success flow: reset user state, refetch sidebar, and close modal.
|
|
||
| const handleDeleteUserButtonClick = () => { | ||
| deleteUserInfo().then(() => { | ||
| deleteUserInfo().then((res) => { |
There was a problem hiding this comment.
Add a .catch() handler after .then() to handle network or unexpected errors from deleteUserInfo, otherwise promise rejections will be unhandled.
| deleteUserInfo().then(() => { | ||
| deleteUserInfo().then((res) => { | ||
| if (!res.ok) { | ||
| alert(res.body.message || '회원 탈퇴에 실패했습니다.'); |
There was a problem hiding this comment.
[nitpick] Extract the hardcoded error message into a constant or localization bundle to keep translations and strings centralized.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
작업 상세 설명
미리 보기