Feature/#470 팀장은 모든 학습자료 수정 및 삭제 가능하도록 변경 #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables team leaders to edit and delete all study materials, not just their own. Previously, only the original uploader could modify their materials. Now team leaders have full permissions across all materials in their team.
- Added
teamRolefield to Member interface to identify team leaders - Updated document modal to check for team leader status
- Modified footer visibility logic to show edit/delete buttons for team leaders
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types.ts | Added teamRole property to Member interface to support role-based permissions |
| src/containers/study/DocumentModal/index.tsx | Implemented team leader check and updated permission logic for document editing/deletion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
75
to
77
| setIsTeamLeader( | ||
| teamMembers?.some((member: Member) => member.id === user.memberId && member.teamRole === 'ROLE_팀장'), | ||
| ); |
There was a problem hiding this comment.
The hardcoded string 'ROLE_팀장' should be extracted to a constant or enum. This makes the code more maintainable and prevents typos when checking team roles elsewhere in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
미리 보기