Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Do not Overwrite PC::Redistribute #833

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 7, 2025

This is actually already exposed in pyAMReX. The binding here overwrote it and, problematically, did not define the proper default arguments that go into Redistribute(...). Just removing it thus solves this and removes the sloppy duplication that I added by accident.

This is actually already exposed in pyAMReX. The binding here
overwrote it and, problematically, did not define the proper
default arguments that go into `Redistribute(...)`. Just removing
it thus solves this and removes the sloppy duplication that I
added by accident.
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: python Python bindings labels Feb 7, 2025
@ax3l ax3l requested a review from cemitch99 February 7, 2025 07:36
@ax3l ax3l changed the title Python: Do not Overwrite PC::Redistribute Python: Do not Overwrite PC::Redistribute Feb 7, 2025
@ax3l ax3l mentioned this pull request Feb 7, 2025
3 tasks
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ax3l ax3l merged commit 8077b99 into BLAST-ImpactX:development Feb 7, 2025
16 checks passed
@ax3l ax3l deleted the remove-py-redistribute branch February 7, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: python Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants