Utilize shared state in dashboard #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the state change converts the input value from a string to a numeric, we do not want the input value to be read in numerous times.
can't include others (distribution parameters/lattice config/space charge because either their states are nested by dictionary use or they use different validation errors. In the future, it would be good to have a single validation function than multiple separate ones.
proy30
force-pushed
the
dashboard/use_global_state
branch
from
18b720b to
367ce8d
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the new shared state functionality to simplify the dashboard code. Instead of making controller calls for tasks like validation and numeric conversion, we now use a single state change callback to handle these actions efficiently. This reduces redundant code and improves maintainability.
The changes in this PR apply to the input parameters and CSR sections. The distribution, space charge, and lattice configuration sections are not using the shared state approach due to their nested state structures.
Additionally, the docstring of the custom
text_fieldmethod is updated for clarity.