Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix RST Syntax #835

Merged
merged 5 commits into from
Feb 9, 2025
Merged

Doc: Fix RST Syntax #835

merged 5 commits into from
Feb 9, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 8, 2025

Carefully fix RST Syntax in documentation, primarily for the parameters.rst file and in particular for nested bullet lists. Also fix other Sphinx warnings on the way. Improve accessibility (linking to elements, sorting).

@ax3l ax3l added the component: documentation Docs, readme and manual label Feb 8, 2025
@ax3l ax3l requested review from n01r and cemitch99 February 8, 2025 22:17
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Feb 8, 2025
@@ -7,7 +7,7 @@ In ImpactX, one can easily add new beamline elements as a user.
There are multiple ways to add new elements to ImpactX, you can pick the one that fits your needs best.

The workflows described here apply both for thin kicks or thick elements.
Thick elements can also use soft-edged fringe fields (see `existing soft-edged elements for implementation details <https://github.com/ECP-WarpX/impactx/tree/development/src/particles/elements>`__).
Copy link
Member Author

@ax3l ax3l Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was forgotten in #828

@ax3l ax3l force-pushed the fix-rst-parms branch 2 times, most recently from e9b90a5 to 212764b Compare February 8, 2025 22:21
Carefully fix RST Syntax in documentation, primarily for the
`parameters.rst` file and in particular for nested bullet lists.
Also fix other Sphinx warnings on the way.
ax3l added 2 commits February 8, 2025 14:37
Makes this long list easier to read, creates a TOC entry for
each element, and allow us to link to individual elements.
@ax3l
Copy link
Member Author

ax3l commented Feb 8, 2025

Ah, this makes me happy
image

Preview: https://impactx--835.org.readthedocs.build/en/835/usage/parameters.html#buncher

Ready for merge :)

@ax3l
Copy link
Member Author

ax3l commented Feb 8, 2025

I find the sbend_exact references very hard to google.

@cemitch99 maybe we could add the paper titles and links to DOIs/JACoW for D. L. Bruhwiler et al., in Proc. of EPAC 98, pp. 1171-1173 (1998) and E. Forest et al., Part. Accel. 45, pp. 65-94 (1994)?

@ax3l ax3l merged commit b7a99e7 into BLAST-ImpactX:development Feb 9, 2025
16 checks passed
@ax3l ax3l deleted the fix-rst-parms branch February 9, 2025 20:16
Copy link
Member

@n01r n01r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: documentation Docs, readme and manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants