Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Improve UI for Inputs #855

Open
wants to merge 32 commits into
base: development
Choose a base branch
from

Conversation

proy30
Copy link
Member

@proy30 proy30 commented Feb 20, 2025

This PR improves the existing dashboard Inputs UI by:

  • Improving Flexibility
    • Moves away from a fixed layout structure to a more responsive UI that adapts to different screen sizes (both large and small).
  • Establishing Consistency with UI Elements
    • Introduces UIDefaults class that centralizes key component styles. While the current UI is mostly consistent in terms of its look, this PR unifies any mismatched styles and also improves code readability.
    • Converting icons to actual buttons
    • Updating input_header component to allow the flexibility of positioning header buttons
  • Updating the lattice configuration look

proy30 and others added 27 commits February 12, 2025 12:13
This is part of the goal of having the Inputs take up 50% of the page only, leaving the right 50% for future visualization additions.
 It does not look like it is needed
So that the line of code is not hidden deeply and can easily read from the 'outside'
Need to assign 'auto' instead as we want checkboxes to be next to each other.. this is primarily making space for future PR to allow space for 'select mode' select field
This is to ensure that the input section can function on a smaller screen
Does not require to 'show_details' as there it is not expected for a dropdown to have validation
Making it not expand past the toolbar
To improve responsiveness and user expectations
Alter input_header function to allow more flexibility on button placement, update space_charge header because of this. Additionally, the lattice config is inside one vcard rather than two separate, and the icons are treated as actual buttons with an icon.
@proy30
Copy link
Member Author

proy30 commented Feb 20, 2025

The input section prior to PR (on a laptop-sized screen):
chrome_VcA3X88cwe
The sizes of each section are fixed, so while the inputs look fine on a decently sized screen, the dashboard gives some difficult to utilize on a smaller screen size.

The input section after the PR (on a laptop-sized screen):
chrome_NrlUYPgTyh
The inputs are strictly set to take 50% of the page, regardless of screen size, while the remaining 50% is left for pre-sim visualizations when added.

@proy30
Copy link
Member Author

proy30 commented Feb 20, 2025

Lattice Config Before Lattice Config After
Image1 Image2
Lattice Config Expanded Before Lattice Config Expanded After
Image3 Image4

@proy30
Copy link
Member Author

proy30 commented Feb 20, 2025

Space Charge Before Space Charge After
Space Charge Before Space Charge After

The bolded headings in the before are not consistent with other UI input labels.

@proy30 proy30 changed the title [WIP] Dashboard: Improve UI for Inputs Dashboard: Improve UI for Inputs Feb 21, 2025
@proy30 proy30 added the component: dashboard our browser based trame dashboard label Feb 21, 2025
@proy30 proy30 requested review from ax3l, cemitch99 and EZoni February 21, 2025 00:43
@ax3l ax3l self-assigned this Feb 21, 2025
@ax3l
Copy link
Member

ax3l commented Feb 21, 2025

The scrolling that is now default for most screen sizes inside boxes is a bit cumbersome in terms of UI/UX, I think. What about this: adding the option to collapse a box by clicking on its title to save space? That would be more natural, because some boxes one sets once while one works with other boxes repeatedly.

@proy30 proy30 changed the title Dashboard: Improve UI for Inputs [WIP] Dashboard: Improve UI for Inputs Feb 21, 2025
@proy30
Copy link
Member Author

proy30 commented Feb 22, 2025

Demo with no scroll bars, expandable and collapsible sections.

chrome_9XngD2zFsE.mp4

@proy30
Copy link
Member Author

proy30 commented Feb 22, 2025

And add "collapse all" in toolbar

chrome_dwLXHBxk8f.mp4

@proy30 proy30 changed the title [WIP] Dashboard: Improve UI for Inputs Dashboard: Improve UI for Inputs Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard our browser based trame dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants