Skip to content

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 18, 2025

Add a runner for single precision tests in CI.

  • make s-to-t / t-to-s transform more robust?
  • make reduced beam characteristics more robust?
  • adjust tolerances

@ax3l ax3l added the component: tests examples, tests and benchmarks label Mar 18, 2025
@ax3l ax3l requested a review from cemitch99 March 18, 2025 05:19
Add a runner for single precision tests in CI.
@ax3l ax3l force-pushed the ci-single-precision branch from f45c627 to eed1fa9 Compare March 18, 2025 05:22
Slight relaxation to account for SP precision.
@ax3l ax3l changed the title CI: ImpactX Single Precision [WIP] CI: ImpactX Single Precision Mar 18, 2025
@ax3l ax3l added the help wanted Extra attention is needed label Mar 18, 2025
@ax3l
Copy link
Member Author

ax3l commented Mar 18, 2025

Looking at the t-to-s / s-to-t test in tests/python/test_transformation.py, which underlies the space charge implementation, I think that either that transformation or the ReducedBeamDiagnostics that we use to validate it need improvements to deal better with single precision.

We might be able to re-formulate/taylor the expressions in the transformations where we have terms like -1.0 + 1.000001 first:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: tests examples, tests and benchmarks help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant