Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] upload snap to snapstore #6073

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[ci] upload snap to snapstore #6073

wants to merge 1 commit into from
+19 −0

Conversation

AenBleidd
Copy link
Member

No description provided.

@AenBleidd
[ci] upload snap to snapstore
3878811 
Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd AenBleidd added this to the Client/Manager 8.2.0 milestone Feb 13, 2025
@Copilot Copilot bot review requested due to automatic review settings February 13, 2025 00:30
Copilot
Copilot AI reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

.github/workflows/snap.yml
@@ -64,6 +64,16 @@ jobs:
run: |
echo "VCPKG_BINARY_SOURCES=clear;x-aws-config,no-sign-request;x-aws,s3://vcpkg.cache.boinc/,read" >> $GITHUB_ENV

- name: Fix version in the snapcraft.yaml
run: |
PKG_VERSION=$(cat version.h | grep BOINC_VERSION_STRING | sed -e 's|#define BOINC_VERSION_STRING||' | jq -r .)
Copy link
Preview

Copilot AI Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'jq' here is incorrect as it is typically used for JSON parsing. It should be removed from the command.

Suggested change
PKG_VERSION=$(cat version.h | grep BOINC_VERSION_STRING | sed -e 's|#define BOINC_VERSION_STRING||' | jq -r .)
PKG_VERSION=$(cat version.h | grep BOINC_VERSION_STRING | sed -e 's|#define BOINC_VERSION_STRING||' | tr -d '[:space:]')

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@AenBleidd AenBleidd linked an issue Feb 13, 2025 that may be closed by this pull request
[Snap] Prepare snap package for automated release #5108
Open
2 tasks
@AenBleidd AenBleidd marked this pull request as draft February 13, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
C: Build System OS: Linux - snapcraft PR: Enhancement
Projects
Client/Manager
Status: In progress
Milestone
Client/Manager 8.2.0
Development

Successfully merging this pull request may close these issues.

[Snap] Prepare snap package for automated release
1 participant
@AenBleidd