Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding pgm index #43

Merged
merged 4 commits into from
Jan 21, 2025
Merged

adding pgm index #43

merged 4 commits into from
Jan 21, 2025

Conversation

JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Oct 17, 2024

Added Functionality:

@JslYoon JslYoon self-assigned this Oct 17, 2024
ramananeesh
ramananeesh reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Mostly looks good, but I still don't see the simple unit tests that @ephoris mentioned to include.

ephoris
ephoris approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ramananeesh
Copy link
Collaborator

@JslYoon let's merge this to main as it has all required approvals.

@JslYoon JslYoon merged commit dd9a130 into main Jan 21, 2025
1 check passed
@JslYoon JslYoon deleted the JslYoon/PGM-index branch January 21, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephoris ephoris ephoris approved these changes

@ramananeesh ramananeesh ramananeesh approved these changes

Assignees

@JslYoon JslYoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JslYoon @ramananeesh @ephoris